Skip to content

Test: arm_sgp_summer_1997_A SCM_WoFS_v0 CI#607

Closed
scrasmussen wants to merge 2 commits into
NCAR:mainfrom
scrasmussen:bugfix/arm_WoFS
Closed

Test: arm_sgp_summer_1997_A SCM_WoFS_v0 CI#607
scrasmussen wants to merge 2 commits into
NCAR:mainfrom
scrasmussen:bugfix/arm_WoFS

Conversation

@scrasmussen
Copy link
Copy Markdown
Member

Not a fix yet, just demonstrating where the error is.

SOURCE: Soren Rasmussen, NSF NCAR

DESCRIPTION OF CHANGES:

IF( ssat0(mgs) .GT. 0. .OR. ssf(mgs) .GT. 0. ) GO TO 620

TESTS CONDUCTED: The PR CI is the test. It breaks on the following CI test

 | arm_sgp_summer_1997_A | SCM_WoFS_v0 | input_WoFS_v0.nml |

@scrasmussen scrasmussen marked this pull request as draft August 7, 2025 00:06
@scrasmussen scrasmussen mentioned this pull request Aug 7, 2025
Explicit check for NaNs where WoFS was breaking
@scrasmussen
Copy link
Copy Markdown
Member Author

The CI is passing now for all the tests. The remaining question for this PR is if the fix of initializing ssfilt to 0 is valid or if the CI is breaking due to bad input data or issues in the code somewhere else.

@grantfirl
Copy link
Copy Markdown
Collaborator

Replaced by #613

@grantfirl grantfirl closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants